Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter and error for code submissions that use global scope variables / methods #8974

Merged
merged 15 commits into from
Jul 3, 2024
Merged

Add linter and error for code submissions that use global scope variables / methods #8974

merged 15 commits into from
Jul 3, 2024

Conversation

khoaguin
Copy link
Member

@khoaguin khoaguin self-assigned this Jun 26, 2024
@khoaguin khoaguin changed the title Code submissions linter error [WIP] Add linter and error for code submissions that use global scope variables / methods Jun 26, 2024
@khoaguin khoaguin changed the title [WIP] Add linter and error for code submissions that use global scope variables / methods Add linter and error for code submissions that use global scope variables / methods Jul 1, 2024
@madhavajay madhavajay added this to the 24Q3 - G1M2 Organic Fixes milestone Jul 1, 2024
@khoaguin @shubham3121
[syft/user_code] try to parse and unparse user code both on the clien…
a589ad3 
…t and server side

- remove parsing user code in local call since it was already parsed before

Co-authored-by: Shubham Gupta <[email protected]>
@khoaguin
Copy link
Member Author

khoaguin commented Jul 1, 2024 •
edited
Loading

Hi @IrinaMBejan, currently the fix is like below
image

Also the way we do it now is to put the check in the syft_function decorator to run it locally first before submitting to the server

shubham3121
shubham3121 requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khoaguin left a few minor comments, otherwise LGTM !! 💯

packages/syft/src/syft/service/code/user_code.py Outdated Show resolved Hide resolved
packages/syft/src/syft/service/code/user_code.py Outdated Show resolved Hide resolved
packages/syft/src/syft/service/code/user_code.py Show resolved Hide resolved
@shubham3121 shubham3121 merged commit 316ff6a into OpenMined:dev Jul 3, 2024
23 checks passed
@khoaguin khoaguin deleted the code-submissions-linter-error branch July 3, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham3121 shubham3121 shubham3121 approved these changes

Assignees

@khoaguin khoaguin

Labels
0.8.7 Yellow Team
Projects
None yet
Milestone
24Q3 - G1M2 Organic Fixes
Development

Successfully merging this pull request may close these issues.
3 participants
@khoaguin @shubham3121 @madhavajay